Skip to content

Use a thread local StringBuilder to avoid creating garbage #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Use a thread local StringBuilder to avoid creating garbage #83

wants to merge 1 commit into from

Conversation

@tobiasstadler
Copy link
Contributor

@tobiasstadler tobiasstadler commented Jul 26, 2020 •
edited by zube bot
Loading

No description provided.

@ghost
Copy link

ghost commented Jul 26, 2020 •
edited by ghost
Loading

❕ Build Aborted

The PR is not allowed to run in the CI yet

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Reason: The PR is not allowed to run in the CI yet

  • Start Time: 2021-07-07T10:31:21.585+0000

  • Duration: 3 min 4 sec

  • Commit: 21a0b5b

Trends 🧪

Image of Build Times

Steps errors 2

Expand to view the steps failures

Load a resource file from a shared library
  • Took 0 min 0 sec . View more details on here
  • Description: approval-list/elastic/ecs-logging-java.yml
Error signal
  • Took 0 min 0 sec . View more details on here
  • Description: githubPrCheckApproved: The PR is not allowed to run in the CI yet. (Only users with write permissions can do so.)

Log output

Expand to view the last 100 lines of log output 

[2021-07-07T10:31:38.172Z] Commit message: "Merge commit '0f8c44cf406ea117d30bbbd5f9691b1aaec34e30' into HEAD"
[2021-07-07T10:31:38.172Z]  > git rev-list --no-walk 184ac5ce53bed513803b17e9b3b74c7e05724a72 # timeout=10
[2021-07-07T10:31:38.178Z] First time build. Skipping changelog.
[2021-07-07T10:31:38.178Z] Cleaning workspace
[2021-07-07T10:31:38.178Z]  > git rev-parse --verify HEAD # timeout=10
[2021-07-07T10:31:38.184Z] Resetting working tree
[2021-07-07T10:31:38.184Z]  > git reset --hard # timeout=10
[2021-07-07T10:31:38.202Z]  > git clean -fdx # timeout=10
[2021-07-07T10:31:38.782Z] Masking supported pattern matches of $JOB_GCS_BUCKET or $NOTIFY_TO
[2021-07-07T10:31:38.829Z] Timeout set to expire in 1 hr 0 min
[2021-07-07T10:31:38.839Z] The timestamps step is unnecessary when timestamps are enabled for all Pipeline builds.
[2021-07-07T10:31:53.893Z] Still waiting to schedule task
[2021-07-07T10:31:53.893Z] All nodes of label ‘linux&&immutable’ are offline
[2021-07-07T10:33:54.973Z] Running on apm-ci-immutable-ubuntu-1804-1625653910616723275 in /var/lib/jenkins/workspace/_java_ecs-logging-java-mbp_PR-83
[2021-07-07T10:34:01.274Z] [INFO] 'shallow' is forced to be disabled when running on PullRequests
[2021-07-07T10:34:01.287Z] Running in /var/lib/jenkins/workspace/_java_ecs-logging-java-mbp_PR-83/src/github.com/elastic/ecs-logging-java
[2021-07-07T10:34:01.301Z] [INFO] gitCheckout: Checkout SCM PR-83 with default customisation from the Item.
[2021-07-07T10:34:01.323Z] [INFO] Override default checkout
[2021-07-07T10:34:01.353Z] Sleeping for 10 sec
[2021-07-07T10:34:11.375Z] The recommended git tool is: NONE
[2021-07-07T10:34:14.185Z] using credential f6c7695a-671e-4f4f-a331-acdce44ff9ba
[2021-07-07T10:34:14.194Z] Wiping out workspace first.
[2021-07-07T10:34:14.210Z] Cloning the remote Git repository
[2021-07-07T10:34:14.210Z] Using shallow clone with depth 3
[2021-07-07T10:34:14.210Z] Avoid fetching tags
[2021-07-07T10:34:14.246Z] Cloning repository git@github.com:elastic/ecs-logging-java.git
[2021-07-07T10:34:14.330Z]  > git init /var/lib/jenkins/workspace/_java_ecs-logging-java-mbp_PR-83/src/github.com/elastic/ecs-logging-java # timeout=10
[2021-07-07T10:34:14.394Z] Fetching upstream changes from git@github.com:elastic/ecs-logging-java.git
[2021-07-07T10:34:14.394Z]  > git --version # timeout=10
[2021-07-07T10:34:14.409Z]  > git --version # 'git version 2.17.1'
[2021-07-07T10:34:14.410Z] using GIT_SSH to set credentials GitHub user @elasticmachine SSH key
[2021-07-07T10:34:14.454Z]  > git fetch --no-tags --progress -- git@github.com:elastic/ecs-logging-java.git +refs/heads/*:refs/remotes/origin/* # timeout=15
[2021-07-07T10:34:15.263Z] Cleaning workspace
[2021-07-07T10:34:15.287Z] Using shallow fetch with depth 3
[2021-07-07T10:34:15.287Z] Pruning obsolete local branches
[2021-07-07T10:34:15.887Z] Merging remotes/origin/master commit 0f8c44cf406ea117d30bbbd5f9691b1aaec34e30 into PR head commit 21a0b5b709aa04e52896d8b910a75521bb19ba03
[2021-07-07T10:34:15.995Z] Merge succeeded, producing 4ecb67b1ddf45307654713b5726cf30f2d3913c8
[2021-07-07T10:34:15.996Z] Checking out Revision 4ecb67b1ddf45307654713b5726cf30f2d3913c8 (PR-83)
[2021-07-07T10:34:15.221Z]  > git config remote.origin.url git@github.com:elastic/ecs-logging-java.git # timeout=10
[2021-07-07T10:34:15.238Z]  > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # timeout=10
[2021-07-07T10:34:15.251Z]  > git config remote.origin.url git@github.com:elastic/ecs-logging-java.git # timeout=10
[2021-07-07T10:34:15.267Z]  > git rev-parse --verify HEAD # timeout=10
[2021-07-07T10:34:15.276Z] No valid HEAD. Skipping the resetting
[2021-07-07T10:34:15.276Z]  > git clean -fdx # timeout=10
[2021-07-07T10:34:15.292Z] Fetching upstream changes from git@github.com:elastic/ecs-logging-java.git
[2021-07-07T10:34:15.293Z] using GIT_SSH to set credentials GitHub user @elasticmachine SSH key
[2021-07-07T10:34:15.297Z]  > git fetch --no-tags --progress --prune -- git@github.com:elastic/ecs-logging-java.git +refs/pull/83/head:refs/remotes/origin/PR-83 +refs/heads/master:refs/remotes/origin/master # timeout=15
[2021-07-07T10:34:15.895Z]  > git config core.sparsecheckout # timeout=10
[2021-07-07T10:34:15.901Z]  > git checkout -f 21a0b5b709aa04e52896d8b910a75521bb19ba03 # timeout=15
[2021-07-07T10:34:15.935Z]  > git remote # timeout=10
[2021-07-07T10:34:15.940Z]  > git config --get remote.origin.url # timeout=10
[2021-07-07T10:34:15.945Z] using GIT_SSH to set credentials GitHub user @elasticmachine SSH key
[2021-07-07T10:34:15.948Z]  > git merge 0f8c44cf406ea117d30bbbd5f9691b1aaec34e30 # timeout=10
[2021-07-07T10:34:15.990Z]  > git rev-parse HEAD^{commit} # timeout=10
[2021-07-07T10:34:15.998Z]  > git config core.sparsecheckout # timeout=10
[2021-07-07T10:34:16.003Z]  > git checkout -f 4ecb67b1ddf45307654713b5726cf30f2d3913c8 # timeout=15
[2021-07-07T10:34:19.606Z] Commit message: "Merge commit '0f8c44cf406ea117d30bbbd5f9691b1aaec34e30' into HEAD"
[2021-07-07T10:34:19.629Z] First time build. Skipping changelog.
[2021-07-07T10:34:19.629Z] Cleaning workspace
[2021-07-07T10:34:19.610Z]  > git rev-list --no-walk 184ac5ce53bed513803b17e9b3b74c7e05724a72 # timeout=10
[2021-07-07T10:34:19.631Z]  > git rev-parse --verify HEAD # timeout=10
[2021-07-07T10:34:19.656Z] Resetting working tree
[2021-07-07T10:34:19.657Z]  > git reset --hard # timeout=10
[2021-07-07T10:34:19.687Z]  > git clean -fdx # timeout=10
[2021-07-07T10:34:20.337Z] Masking supported pattern matches of $GIT_USERNAME or $GIT_PASSWORD
[2021-07-07T10:34:20.789Z] + git fetch https://****:****@github.com/elastic/ecs-logging-java.git +refs/pull/*/head:refs/remotes/origin/pr/*
[2021-07-07T10:34:21.098Z] Running in /var/lib/jenkins/workspace/_java_ecs-logging-java-mbp_PR-83/src/github.com/elastic/ecs-logging-java/.git
[2021-07-07T10:34:21.150Z] Archiving artifacts
[2021-07-07T10:34:21.739Z] + git rev-parse HEAD
[2021-07-07T10:34:22.064Z] + git rev-parse HEAD
[2021-07-07T10:34:22.372Z] + git rev-parse origin/pr/83
[2021-07-07T10:34:22.411Z] [INFO] githubEnv: Found Git Build Cause: pr
[2021-07-07T10:34:22.606Z] Masking supported pattern matches of $GITHUB_TOKEN
[2021-07-07T10:34:23.348Z] [WARN] githubApiCall: The REST API call https://api.github.com/repos/elastic/ecs-logging-java/pulls/83/reviews return 0 elements
[2021-07-07T10:34:23.374Z] [INFO] githubPrCheckApproved: Title: Use a thread local StringBuilder to avoid creating garbage - User: tobiasstadler - Author Association: CONTRIBUTOR
[2021-07-07T10:34:23.586Z] ERROR: githubPrCheckApproved: The PR is not allowed to run in the CI yet
[2021-07-07T10:34:23.586Z] ERROR: githubPrCheckApproved: The PR is not allowed to run in the CI yet. (Only users with write permissions can do so.)
[2021-07-07T10:34:23.632Z] [INFO] Let's stop build #23. The PR is not allowed to run in the CI yet
[2021-07-07T10:34:23.643Z] Sleeping for 5 sec
[2021-07-07T10:34:24.676Z] Stage "Build" skipped due to earlier failure(s)
[2021-07-07T10:34:24.745Z] Stage "Tests" skipped due to earlier failure(s)
[2021-07-07T10:34:24.784Z] Stage "Unit Tests" skipped due to earlier failure(s)
[2021-07-07T10:34:24.785Z] Stage "Javadoc" skipped due to earlier failure(s)
[2021-07-07T10:34:24.786Z] Stage "Sanity checks" skipped due to earlier failure(s)
[2021-07-07T10:34:24.792Z] Terminated
[2021-07-07T10:34:24.810Z] Failed in branch Unit Tests
[2021-07-07T10:34:24.811Z] Failed in branch Javadoc
[2021-07-07T10:34:24.810Z] Terminated
[2021-07-07T10:34:24.812Z] Failed in branch Sanity checks
[2021-07-07T10:34:25.052Z] Running on worker-854309 in /var/lib/jenkins/workspace/_java_ecs-logging-java-mbp_PR-83
[2021-07-07T10:34:25.134Z] [INFO] getVaultSecret: Getting secrets
[2021-07-07T10:34:25.177Z] Masking supported pattern matches of $VAULT_ADDR or $VAULT_ROLE_ID or $VAULT_SECRET_ID
[2021-07-07T10:34:27.141Z] + chmod 755 generate-build-data.sh
[2021-07-07T10:34:27.141Z] + ./generate-build-data.sh https://apm-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/apm-agent-java/ecs-logging-java-mbp/PR-83/ https://apm-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/apm-agent-java/ecs-logging-java-mbp/PR-83/runs/23 ABORTED 184159
[2021-07-07T10:34:27.141Z] INFO: curl https://apm-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/apm-agent-java/ecs-logging-java-mbp/PR-83/runs/23/steps/?limit=10000 -o steps-info.json
[2021-07-07T10:34:27.840Z] INFO: curl https://apm-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/apm-agent-java/ecs-logging-java-mbp/PR-83/runs/23/tests/?status=FAILED -o tests-errors.json
[2021-07-07T10:34:28.540Z] Retry 1/3 exited 22, retrying in 1 seconds...
[2021-07-07T10:34:29.988Z] Retry 2/3 exited 22, retrying in 2 seconds...
[2021-07-07T10:34:32.245Z] Retry 3/3 exited 22, no more retries left.
[2021-07-07T10:34:32.245Z] INFO: curl https://apm-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/apm-agent-java/ecs-logging-java-mbp/PR-83/runs/23/log/ -o pipeline-log.txt

@tobiasstadler
Copy link
Contributor Author

tobiasstadler commented Aug 12, 2020

Can anyone please have a look at this?

@felixbarny
Copy link
Member

felixbarny commented Aug 12, 2020

Sorry, I thought I had answered already. I'm not sure this makes a lot of difference. There are still allocations when calling builder.toString() at the end of the method.

@tobiasstadler
Copy link
Contributor Author

tobiasstadler commented Aug 12, 2020

Yes, there we are still allocating "garbage", but not as much as before.

@felixbarny
Copy link
Member

felixbarny commented Aug 14, 2020

The thing is that caching that StringBuilder thread-locally does add memory overhead to each thread that performs logging. By using Logback, you basically have already agreed to use a logging library that does create garbage. If you want a zero-garbage alternative, why not use log4j2? This hybrid approach might just combine the downsides of both - higher memory footprint and still creating garbage.
What's the background of this change? Did you make measurements about how this change would affect your GC counts and times?

@tobiasstadler
Copy link
Contributor Author

tobiasstadler commented Jan 29, 2021

Sorry for the long delay.

I want to use it in Wildfly/JBoss EAP. I did not do any performance testing, but I don't think my change will negatively affect my use case.

@eyalkoren
Copy link
Contributor

eyalkoren commented Jul 7, 2021

@tobiasstadler can we close this one?

@tobiasstadler
Copy link
Contributor Author

tobiasstadler commented Jul 7, 2021

yes

@eyalkoren
Copy link
Contributor

eyalkoren commented Jul 8, 2021

Thanks 🙏

@eyalkoren eyalkoren closed this Jul 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

agent-java

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tobiasstadler @felixbarny @eyalkoren @AlexanderWert